[PATCH] D106947: [DSE][NFC] Rename Later->Killing, Earlier->Killed

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM with a few small nits. Thanks!



================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:340
+/// overwrite one another. More specifically, \p KillingI has to
+/// overwrite \p DeadII.
+static OverwriteResult isMaskedStoreOverwrite(const Instruction *KillingI,
----------------
ebrevnov wrote:
> asbirlea wrote:
> > s/DeadII/DeadI
> Fixed. Thanks for noting.
Looks like this is still `DeadII`?


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:357
   // Masks.
-  // TODO: check that Later's mask is a superset of the Earlier's mask.
-  if (IIL->getArgOperand(3) != IIE->getArgOperand(3))
+  // TODO: check that Killing's mask is a superset of the Dead's mask.
+  if (KillingII->getArgOperand(3) != DeadII->getArgOperand(3))
----------------
`KillingI's mask`?


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:367
+/// if the beginning of the 'DeadLoc' location is overwritten by 'KillingLoc'.
+/// 'OW_PartialEarlierWithFullLater' means that an Dead (big) store was
+/// overwritten by a killing (smaller) store which doesn't write outside the big
----------------
`a dead (big) store`?


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:440
 
-  // Check for an earlier store which writes to all the memory locations that
-  // the later store writes to.
-  if (EnablePartialStoreMerging && LaterOff >= EarlierOff &&
-      int64_t(EarlierOff + EarlierSize) > LaterOff &&
-      uint64_t(LaterOff - EarlierOff) + LaterSize <= EarlierSize) {
-    LLVM_DEBUG(dbgs() << "DSE: Partial overwrite an earlier load ["
-                      << EarlierOff << ", "
-                      << int64_t(EarlierOff + EarlierSize)
-                      << ") by a later store [" << LaterOff << ", "
-                      << int64_t(LaterOff + LaterSize) << ")\n");
+  // Check for an dead store which writes to all the memory locations that
+  // the killing store writes to.
----------------
`a dead store`


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:445
+      uint64_t(KillingOff - DeadOff) + KillingSize <= DeadSize) {
+    LLVM_DEBUG(dbgs() << "DSE: Partial overwrite an dead load [" << DeadOff
+                      << ", " << int64_t(DeadOff + DeadSize)
----------------
`a dead load`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106947/new/

https://reviews.llvm.org/D106947