[PATCH] D109637: [llvm-profgen] Ignore broken LBR samples

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:642
     if (EndOffeset != 0) {
       assert(StartOffset <= EndOffeset &&
              "Bogus range should be filtered ealier!");
----------------
wlei wrote:
> Please help to remove this line since it's already done in `recordRangeCount`.
Good catch. Assert removed.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.h:376
   void recordRangeCount(uint64_t Start, uint64_t End, uint64_t Repeat) {
+    assert(Start <= End && "invalid instruction range");
     RangeCounter[{Start, End}] += Repeat;
----------------
wlei wrote:
> Nit: invalid --> Invalid , same for other assert message.
Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109637/new/

https://reviews.llvm.org/D109637