[PATCH] D109637: [llvm-profgen] Ignore broken LBR samples

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 13 12:57:46 PDT 2021


wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:642
     if (EndOffeset != 0) {
       assert(StartOffset <= EndOffeset &&
              "Bogus range should be filtered ealier!");
----------------
Please help to remove this line since it's already done in `recordRangeCount`.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.h:376
   void recordRangeCount(uint64_t Start, uint64_t End, uint64_t Repeat) {
+    assert(Start <= End && "invalid instruction range");
     RangeCounter[{Start, End}] += Repeat;
----------------
Nit: invalid --> Invalid , same for other assert message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109637/new/

https://reviews.llvm.org/D109637



More information about the llvm-commits mailing list