[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

Mon Sep 13 12:47:18 PDT 2021

catenacyber added a comment.

> Even if `INSTR_PROF_RAW_VERSION` is bumped, I think it is very likely your Rust downstream will observe an `if (GET_VERSION(Version) != RawInstrProf::Version)` error in llvm-profdata,
> because from your description it seems you are likely mixing raw profile files produced by compiler-rt/lib/profile built at different commits.

For the record, bumping `INSTR_PROF_RAW_VERSION` on top of main branch, (or after reverting this commit), in both compiler-rt/include/profile/InstrProfData.inc and llvm/include/llvm/ProfileData/InstrProfData.inc, I indeed get the error message `unsupported instrumentation profile format version`

The output for `file default.profraw` is `default.profraw: LLVM raw profile data, version 7`

> Bumping INSTR_PROF_RAW_VERSION will give a better diagnostic but won't address the root cause that only one version is supported, which I totally agree since otherwise this would add too much burden on the upstream LLVM developer side.

Well, now I have my diagnostic :-) (it is not like https://github.com/rust-lang/rust/issues/82875 for instance)

> this is "Support for older format versions in RawInstrProfReader" https://lists.llvm.org/pipermail/llvm-dev/2021-August/152287.html

Thanks for the pointer

> You'll need to rebuild everything on the Rust side if you want to use git LLVM.

Indeed, I will try to rebuild rust with clang-14

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104556/new/

https://reviews.llvm.org/D104556