[PATCH] D107070: [Dexter] Improve Dexter's performance by evaluating expressions only when needed

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexExpectProgramState.py:72
+                        frame_idx=idx,
+                        line_range=line_range
+                    )
----------------
jmorse wrote:
> Is this going to lead to multiple StepExpectInfo objects referring to the same range object? And if so, doesn't that mean consuming the range in one frame will consume it in all the frames?
> 
> (If so, easily fixed by converting to a list).
I don't think so - the frame index is in the StepExpectInfo tuple, so unless the same value is being watched twice in the same stack frame there shouldn't be duplicates (and if there are then we should merge them).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107070/new/

https://reviews.llvm.org/D107070