[PATCH] D107070: [Dexter] Improve Dexter's performance by evaluating expressions only when needed

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM with one inline question -- if that's an issue, fine to land with the obvious fix.



================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexExpectProgramState.py:72
+                        frame_idx=idx,
+                        line_range=line_range
+                    )
----------------
Is this going to lead to multiple StepExpectInfo objects referring to the same range object? And if so, doesn't that mean consuming the range in one frame will consume it in all the frames?

(If so, easily fixed by converting to a list).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107070/new/

https://reviews.llvm.org/D107070