[PATCH] D109578: [LNT] Fixed incomplete feature for submit JSON to a local instance

[Dmitry Vassiliev via Phabricator via llvm-commits]

slydiman added inline comments.


================
Comment at: lnt/lnttool/main.py:194-197
+    if '://' not in url:
+        init_logger(logging.DEBUG)
+        register_hooks()
+
----------------
thopre wrote:
> Why is this necessary?
Note if the url contains the link to the server everything will be submitted and processed on the server where hooks and logs are already initialized. But if the url is a local path to the instance everything will be processed locally inside this process. It is necessary to register hooks to process regressions correctly. And it is necessary to init stdout logs too.  Note the url condition is the same as in ServerUtil.py, line 92.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109578/new/

https://reviews.llvm.org/D109578