[PATCH] D109578: [LNT] Fixed incomplete feature for submit JSON to a local instance

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: lnt/lnttool/main.py:188
+ at click.option("--testsuite", "-s", default='nts', show_default=True,
+              help="testsuite to use in case of url is a path to instance")              
+def action_submit(url, files, select_machine, merge, verbose, testsuite):
----------------



================
Comment at: lnt/lnttool/main.py:194-197
+    if '://' not in url:
+        init_logger(logging.DEBUG)
+        register_hooks()
+
----------------
Why is this necessary?


================
Comment at: lnt/server/db/rules/rule_update_fixed_regressions.py:119
         if impacts(session, ts, run_id, regression) and is_fixed(session, ts, regression):
-            logger.info("Detected fixed regression" + str(regression))
+            logger.info("Detected fixed regression " + str(regression))
             regression.state = RegressionState.IGNORED
----------------
Spurious change, please split into a separate patch. Likewise for the two below whitespace changes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109578/new/

https://reviews.llvm.org/D109578