[PATCH] D109294: [Inline] Remove dead users before checking if function has one use (PR51667)

[Mircea Trofin via llvm-commits]

I think we're talking about different things, sorry if I miscommunicated.
My concern is this: say you have a pass. The pass modifies IR
(specifically, deletes Constants). Should the pass manager be informed of
that so it may appropriately invalidate analyses?

On Sat, Sep 11, 2021 at 11:44 AM Roman Lebedev via Phabricator <
reviews at reviews.llvm.org> wrote:

> lebedev.ri added a comment.
>
> In D109294#2996057 <https://reviews.llvm.org/D109294#2996057>, @mtrofin
> wrote:
>
> > An analysis could count uses, for example; or could enumerate constants
> in
> > a module and refine some calculation from that set, but
> > removeDeadUsersOfConstant may delete some such constants.
>
> I think, there is a lot of things that could happen,
> but if llvm development is driven by FUD,
> as opposed to written guarantees and test-cases,
> a forward progress may be somewhat restricted.
>
> > (what's a "VH-like thing"?)
>
> `ValueHandle`, so that the use is actually kept alive,
> not just by a rouge constant expression.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D109294/new/
>
> https://reviews.llvm.org/D109294
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210911/0675d2c5/attachment.html>