[PATCH] D109294: [Inline] Remove dead users before checking if function has one use (PR51667)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 11 11:44:54 PDT 2021


lebedev.ri added a comment.

In D109294#2996057 <https://reviews.llvm.org/D109294#2996057>, @mtrofin wrote:

> An analysis could count uses, for example; or could enumerate constants in
> a module and refine some calculation from that set, but
> removeDeadUsersOfConstant may delete some such constants.

I think, there is a lot of things that could happen,
but if llvm development is driven by FUD,
as opposed to written guarantees and test-cases,
a forward progress may be somewhat restricted.

> (what's a "VH-like thing"?)

`ValueHandle`, so that the use is actually kept alive,
not just by a rouge constant expression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109294/new/

https://reviews.llvm.org/D109294



More information about the llvm-commits mailing list