[PATCH] D109528: [AArch64][GlobalISel] Add a new reassociation for G_PTR_ADDs.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 18:55:53 PDT 2021


aemerson added a comment.

In D109528#2995698 <https://reviews.llvm.org/D109528#2995698>, @paquette wrote:

> test for multiple blocks?

There’s no special code to handle it so there’s no test. I removed the different-blocks check + test in the latest revision.



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4122
+  // G_PTR_ADD (G_PTR_ADD X, C), Y) -> (G_PTR_ADD (G_PTR_ADD(X, Y), C)
+  // iif (G_PTR_ADD X, C) has one use.
+  Register LHSBase;
----------------
paquette wrote:
> do you mean iff or if?
iif


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109528/new/

https://reviews.llvm.org/D109528



More information about the llvm-commits mailing list