[PATCH] D109528: [AArch64][GlobalISel] Add a new reassociation for G_PTR_ADDs.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

test for multiple blocks?



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4122
+  // G_PTR_ADD (G_PTR_ADD X, C), Y) -> (G_PTR_ADD (G_PTR_ADD(X, Y), C)
+  // iif (G_PTR_ADD X, C) has one use.
+  Register LHSBase;
----------------
do you mean iff or if?


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4132
+    // When we change LHSPtrAdd's offset register we might cause it to use a reg
+    // before it's def. Sink the instruction so the outer PTR_ADD to ensure this
+    // doesn't happen.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109528/new/

https://reviews.llvm.org/D109528