[PATCH] D108602: [RISCV] Initial support .insn directive for the assembler.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2254
+
+  if (ParseInstruction(Info, FormatName, L, Operands))
+    return true;
----------------
MaskRay wrote:
> seems that you can omit `L` since the opcode is always correct.
> 
> Then the argument can be deleted.
L is also passed to MatchAndEmitInstruction and is used for "too few operands for instruction". I guess I could point that at the format operand instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108602/new/

https://reviews.llvm.org/D108602