[PATCH] D108602: [RISCV] Initial support .insn directive for the assembler.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 10 17:29:27 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2254
+
+  if (ParseInstruction(Info, FormatName, L, Operands))
+    return true;
----------------
seems that you can omit `L` since the opcode is always correct.

Then the argument can be deleted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108602/new/

https://reviews.llvm.org/D108602



More information about the llvm-commits mailing list