[PATCH] D102266: Recommit "[LAA] Support pointer phis in loop by analyzing each incoming pointer."

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

IMHO, this and D109381 <https://reviews.llvm.org/D109381> only make sense together. Either we do register in-loop PHINodes in accesses or we do not. A PHI value might be used directly as well as indirectly giving us a mix of some PHINodes added to AddPointer while others are not. Always (also) registering the PHINode itself at least would not give use regressions. If we consider a PHINode in the accesses list a bug, could you add an assertion for it?

I'd LGTM this patch if either you promise to commit it together with D109381 <https://reviews.llvm.org/D109381> or merge them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102266/new/

https://reviews.llvm.org/D102266