[PATCH] D102266: Recommit "[LAA] Support pointer phis in loop by analyzing each incoming pointer."

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D102266#2983003 <https://reviews.llvm.org/D102266#2983003>, @Meinersbur wrote:

> Should the PHINode itself also be added to the Accesses list? Or is there a guarantee that it is never queried?

I don't think it should be added, I think it's best to handle both the dependency check and runtime check cases in the same fashion. Otherwise it might get a bit confusing if the tracked pointers diverge. If there are any  places that would still query the phi node, those would need to be fixed. Adding the phi node might hide such issues. WDYT?



================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:1274
+    for (const Use &Inc : PN->incoming_values())
+      AddPointer(Inc);
+  } else
----------------
Meinersbur wrote:
> Should this be recursive, the incoming value might be a PHI inside the InnermostLoop as well?
Yes, that would allow to catch more cases. I put up D109381


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102266/new/

https://reviews.llvm.org/D102266