[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 04:23:55 PDT 2021


c-rhodes added a comment.

In D109489#2991261 <https://reviews.llvm.org/D109489#2991261>, @jansvoboda11 wrote:

> LGTM.
>
> To give more background, I think my intention was to add an assertion that `name` and `other_name` are the same (except for the `no_` part) and I was waiting for TableGen assertions to land. But I don't think that's too valuable, since the callers already ensure that by some other mechanism. This should be fine to remove.

No worries thanks for clarifying!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109489/new/

https://reviews.llvm.org/D109489



More information about the llvm-commits mailing list