[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

Jan Svoboda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 9 03:52:03 PDT 2021


jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.

LGTM.

To give more background, I think my intention was to add an assertion that `name` and `other_name` are the same (except for the `no_` part) and I was waiting for TableGen assertions to land. But I don't think that's too valuable, since the callers already ensure that by some other mechanism. This should be fine to remove.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109489/new/

https://reviews.llvm.org/D109489



More information about the llvm-commits mailing list