[PATCH] D109134: [MemorySSA] Support invariant.group metadata

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.

LGTM as well.



================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:2495
+  // current function.
+  if (isa<GlobalValue>(PointerOperand))
+    return nullptr;
----------------
aeubanks wrote:
> nikic wrote:
> > Shouldn't this skip `isa<Constant>` in general? I think you could reach here with a constant expression (say an inttoptr expression).
> hmm for some reason I thought most `Constant`s had empty use lists, but that's not true
I believe there's plans to move in that direction, but they haven't been implemented yet. (And I also think they would be more in the direction of trying to fetch users of a constant asserts, than being simply empty.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109134/new/

https://reviews.llvm.org/D109134