[PATCH] D109134: [MemorySSA] Support invariant.group metadata

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:2495
+  // current function.
+  if (isa<GlobalValue>(PointerOperand))
+    return nullptr;
----------------
nikic wrote:
> Shouldn't this skip `isa<Constant>` in general? I think you could reach here with a constant expression (say an inttoptr expression).
hmm for some reason I thought most `Constant`s had empty use lists, but that's not true


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109134/new/

https://reviews.llvm.org/D109134