[PATCH] D109423: [PowerPC] Reduce number of virtual registers used when eliminating frameindex

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 06:51:03 PDT 2021


nemanjai added a comment.

Can you please describe why this change is desired? The description seems to indicate that this is completely unnecessary.

While I do realize that we are out of SSA form at this point, I find it a nice conceptual abstraction that code we add only defines each virtual register once. The register scavenger then allocates appropriate physical registers. Unless there is a known problem where the scavenger ends up doing a bad job or the additional virtual registers add significantly to the compilation time, I am not really in favour of this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109423/new/

https://reviews.llvm.org/D109423



More information about the llvm-commits mailing list