[PATCH] D109422: [AArch64][SVE] NFC: Use stepvector directly in index multiclasses

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 8 02:43:05 PDT 2021


paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:1480-1483
-  defm INDEX_RR : sve_int_index_rr<"index", step_vector, step_vector_oneuse, AArch64mul_p_oneuse>;
-  defm INDEX_IR : sve_int_index_ir<"index", step_vector, step_vector_oneuse, AArch64mul_p, AArch64mul_p_oneuse>;
-  defm INDEX_RI : sve_int_index_ri<"index", step_vector, step_vector_oneuse>;
-  defm INDEX_II : sve_int_index_ii<"index", step_vector, step_vector_oneuse>;
----------------
If you're going to hardwire the `step_vector` usage, which I'm fine with by the way, you may as well also hardwire the `mul` operators as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109422/new/

https://reviews.llvm.org/D109422



More information about the llvm-commits mailing list