[PATCH] D108903: [llvm-reduce] Add reduce operands pass

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 14:57:19 PDT 2021


aeubanks added a comment.

In D108903#2987942 <https://reviews.llvm.org/D108903#2987942>, @lebedev.ri wrote:

> Wouldn't it be better to leave the question of with what to replace to a separate patch, and stick to the current consistent practice here?

I don't think it matters too much if we've agreed in the thread that null is better, and we do a followup patch soon where we add a flag and consolidate what we replace things with into a helper method controlled by the flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108903/new/

https://reviews.llvm.org/D108903



More information about the llvm-commits mailing list