[PATCH] D109313: [SelectionDAG] PromoteIntRes_EXTRACT_SUBVECTOR for scalable vectors.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:4741
+      SDValue Step1 = DAG.getNode(ISD::EXTRACT_SUBVECTOR, dl, NInVT, InOp0,
+                                  DAG.getConstant((IdxVal / NElts) * NElts, dl,
+                                                  BaseIdx.getValueType()));
----------------
CarolineConcatto wrote:
> Should this be:
>   DAG.getConstant((IdxVal, dl, ...
> Because:
> (IdxVal / NElts) * NElts =. IdxVal?
Unless this trying to align IdxVal to a multiple of NElts <= IdxVal. In which case it might be clearer as alignDown(IdxVal, NElts)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109313/new/

https://reviews.llvm.org/D109313