[PATCH] D109324: [MSP430] Add support for MSP430X extended shift instructions

Jozef Lawrynowicz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 06:21:30 PDT 2021


jozefl added inline comments.


================
Comment at: llvm/lib/Target/MSP430/MSP430ISelLowering.cpp:1106-1107
+    //
+    // TODO: If op0 is not a register, it would be more efficient to use an Rxx
+    // shift.
+    if (OpSize == 16 && Op.getOpcode() == ISD::SRL)
----------------
There are some pre-existing missed optimizations when shifting memory operands, so I'm going to fix them along with this TODO in a separate commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109324/new/

https://reviews.llvm.org/D109324



More information about the llvm-commits mailing list