[PATCH] D109324: [MSP430] Add support for MSP430X extended shift instructions

Jozef Lawrynowicz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 06:14:48 PDT 2021


jozefl updated this revision to Diff 371055.
jozefl added a comment.

Fixed one of the TODOs:

  // TODO: When shifting by > 8 and opimizing for performance, we should use
  // ShiftBy8, since it saves 6 cycles compared to using an RxxX insn.
  // However, it adds an additional 2 word-sized instructions, so is bad for
  // code size.

Added the appropriate tests.
Also changed some regular comments to Doxygen comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109324/new/

https://reviews.llvm.org/D109324

Files:
  llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp
  llvm/lib/Target/MSP430/Disassembler/MSP430Disassembler.cpp
  llvm/lib/Target/MSP430/MCTargetDesc/MSP430InstPrinter.cpp
  llvm/lib/Target/MSP430/MCTargetDesc/MSP430MCCodeEmitter.cpp
  llvm/lib/Target/MSP430/MSP430ISelDAGToDAG.cpp
  llvm/lib/Target/MSP430/MSP430ISelLowering.cpp
  llvm/lib/Target/MSP430/MSP430ISelLowering.h
  llvm/lib/Target/MSP430/MSP430InstrFormats.td
  llvm/lib/Target/MSP430/MSP430InstrInfo.h
  llvm/lib/Target/MSP430/MSP430InstrInfo.td
  llvm/lib/Target/MSP430/MSP430InstrInfoExtended.td
  llvm/test/CodeGen/MSP430/shift-amount-threshold.ll
  llvm/test/CodeGen/MSP430/shifts-430x-byte.ll
  llvm/test/CodeGen/MSP430/shifts-430x-word.ll
  llvm/test/CodeGen/MSP430/shifts.ll
  llvm/test/MC/MSP430/shifts-430x-invalid.s
  llvm/test/MC/MSP430/shifts-430x.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109324.371055.patch
Type: text/x-patch
Size: 78794 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210907/045f8592/attachment-0001.bin>


More information about the llvm-commits mailing list