[PATCH] D109146: [AArch64][SVE] Replace fmul and fadd LLVM IR instrinsics with fmul and fadd

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 7 05:46:14 PDT 2021


peterwaller-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:703
+
+  if (IsIntrinsic(&II, Intrinsic::aarch64_sve_fmul) &&
+      IsIntrinsic(OpPredicate, Intrinsic::aarch64_sve_convert_from_svbool)) {
----------------
I would prefer to see `if (match(II, m_Intrinsic(Intrinsic::aarch64_sve_fmul))) && ...` which is more idiomatic rather than introducing an IsIntrinsic lambda.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109146/new/

https://reviews.llvm.org/D109146



More information about the llvm-commits mailing list