[PATCH] D108689: [Linker] Support weak symbols in nodeduplicate COMDAT group

Mon Sep 6 10:28:36 PDT 2021

bd1976llvm added a comment.

Thanks for the timely fix :)

I noticed that Comdat::SelectionKind::NoDeduplicate is also used for the code/data added when using sanitizers. Can I get your opinion on whether this fix is sufficient for that case as well?

I looked at D108879 <https://reviews.llvm.org/D108879> but that is only required when there are initializers present and I don't *think* that's the case when using sanitizers - but I'm not very familiar with the area.

Thanks in advance!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108689/new/

https://reviews.llvm.org/D108689