[PATCH] D109082: [AMDGPU] Use S_BITCMP1_* to replace AND in optimizeCompareInstr

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 01:30:18 PDT 2021


foad added a comment.

> I.e. to my view relying on an ISel is a layering violation.

In my view ISel is responsible for selection of instructions, and anything which changes those instructions to different ones later on is a bit of a hack :)

But I take your point about moveToVALU. That does sound a bit awkward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109082/new/

https://reviews.llvm.org/D109082



More information about the llvm-commits mailing list