[PATCH] D109271: [InstCombine] rotate(X,Z) eq/ne rotate(Y,Z) ---> X eq/ne Y (PR51565)

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 4 08:33:56 PDT 2021


xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3266
+static Instruction *foldICmpIntrinsicWithIntrinsic(ICmpInst &Cmp) {
+  if (!Cmp.isEquality())
+    return nullptr;
----------------
spatel wrote:
> This can be an assert, right? We're called only by foldICmpEquality(), so it already checked.
Yeah, I was thinking about it too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109271/new/

https://reviews.llvm.org/D109271



More information about the llvm-commits mailing list