[PATCH] D109271: [InstCombine] rotate(X,Z) eq/ne rotate(Y,Z) ---> X eq/ne Y (PR51565)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 4 08:18:53 PDT 2021


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - see inline for a nit (so might be worth adding the new function as an NFC pre-commit).



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3266
+static Instruction *foldICmpIntrinsicWithIntrinsic(ICmpInst &Cmp) {
+  if (!Cmp.isEquality())
+    return nullptr;
----------------
This can be an assert, right? We're called only by foldICmpEquality(), so it already checked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109271/new/

https://reviews.llvm.org/D109271



More information about the llvm-commits mailing list