[PATCH] D109124: [ARM] Implement target hook function to decide folding (mul (add x, c1), c2)

[Ben Shi via Phabricator via llvm-commits]

benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.h:522
+    bool isMulAddWithConstProfitable(const SDValue &AddNode,
+                                     const SDValue &ConstNode) const override;
+
----------------
RKSimon wrote:
> why are we passing SDValue by const-ref? These things are lightweight enough we normally pass SDValue by value.
No special reason for that. Actually I did not pay attention to that const-ref in my previous patch https://reviews.llvm.org/D107711


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109124/new/

https://reviews.llvm.org/D109124