[PATCH] D109124: [ARM] Implement target hook function to decide folding (mul (add x, c1), c2)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 08:47:57 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.h:522
+    bool isMulAddWithConstProfitable(const SDValue &AddNode,
+                                     const SDValue &ConstNode) const override;
+
----------------
why are we passing SDValue by const-ref? These things are lightweight enough we normally pass SDValue by value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109124/new/

https://reviews.llvm.org/D109124



More information about the llvm-commits mailing list