[PATCH] D108457: [hwasan] Do not instrument accesses to uninteresting allocas.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 3 14:41:56 PDT 2021
eugenis added a comment.
This is pretty cool, I thought it would be more complicated.
This change needs comprehensive tests in llvm/test/Analysis/StackSafetyAnalysis. Update the print() method to show safe/unsafe instructions (or maybe only list known safe instruction).
What if an instruction may access either stack or heap?
i32 *p = flag ? p_heap_i16 : &stack_i32;
*p = 42;
The analysis will say "safe" because it is only scanning from the stack roots.
This should probably be fixed in hwasan by tracking the underlying alloca.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108457/new/
https://reviews.llvm.org/D108457
More information about the llvm-commits
mailing list