[PATCH] D108457: [hwasan] Do not instrument accesses to uninteresting allocas.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 05:24:38 PDT 2021


fmayer added a comment.

In D108457#2963679 <https://reviews.llvm.org/D108457#2963679>, @eugenis wrote:

> In face, isSafeAccess seems pretty limited. Surely ScalarEvolution (similar to how it is used in StackSafetyAnalysis) can capture more cases, including a non-constant offset that can be proven to be within range?

Done. PTAL.

What I do right now is not emit any checks when we can we disable stack instrumentation and we can trace back an operation to an alloca. While we could potentially overflow towards other regions, I think it is not unexpected that we do not catch this if stack instrumentation is disabled. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108457/new/

https://reviews.llvm.org/D108457



More information about the llvm-commits mailing list