[PATCH] D109041: [ARM] Fix assembly in `tInt_eh_sjlj_longjmp`

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 3 06:22:19 PDT 2021


kristof.beyls added a comment.

I'm afraid that I'm not fully up to speed on the code changes here.
That being said, I hope it's useful to point out that I expect that in the not-too-distant future the recent specification of r11 being the frame pointer for both Arm and Thumb to be implemented in LLVM. See https://github.com/ARM-software/abi-aa/blob/main/aapcs32/aapcs32.rst (search for "frame pointer") to see the specification. A frame pointer was only recently added to the ABI specification. Before there was no definition of frame pointer for 32-bit ARM in the ABI specification.

I guess that when the new frame pointer specification gets implemented (both Thumb and Arm use r11 as frame pointer), some of the code in the patch may need to be adapted?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109041/new/

https://reviews.llvm.org/D109041



More information about the llvm-commits mailing list