[PATCH] D109154: [GlobalISel] Improve elimination of dead instructions in legalizer

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 17:20:11 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:2827-2828
     UseMI->eraseFromParent();
+    if (isTriviallyDead(*Cst, MRI))
+      Cst->eraseFromParent();
 
----------------
Why does custom legalization need special casing? Why doesn't the observer get these too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109154/new/

https://reviews.llvm.org/D109154



More information about the llvm-commits mailing list