[PATCH] D109154: [GlobalISel] Improve elimination of dead instructions in legalizer

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 2 14:05:37 PDT 2021


aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Legalizer.cpp:187
+  DeadInstChain.remove(&MI);
+  WrapperObserver.erasingInstr(MI);
+  MI.eraseFromParentAndMarkDBGValuesForRemoval();
----------------
Is this observer call necessary? I thought deletions were automatically handled?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109154/new/

https://reviews.llvm.org/D109154



More information about the llvm-commits mailing list