[PATCH] D109104: [CSSPGO] Allow inlining recursive call for preinliner

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:939
+        Writer(this) {
+    AllowRecursiveCall = Params.AllowRecursiveCall.getValue();
+  }
----------------
wenlei wrote:
> hoy wrote:
> > Nit: move this to the field initializer list? `AllowRecursiveCall(Params.AllowRecursiveCall.getValue())`
> We can't use initializer list directly because that field is in base class (we need it to be in the base because the uses are from base). The params of base's ctor are high level stuff, so I wasn't sure if it's good to add this as a ctor param, and decided to leave it. 
I see, makes sense to leave it as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109104/new/

https://reviews.llvm.org/D109104