[PATCH] D109104: [CSSPGO] Allow inlining recursive call for preinliner

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:939
+        Writer(this) {
+    AllowRecursiveCall = Params.AllowRecursiveCall.getValue();
+  }
----------------
hoy wrote:
> Nit: move this to the field initializer list? `AllowRecursiveCall(Params.AllowRecursiveCall.getValue())`
We can't use initializer list directly because that field is in base class (we need it to be in the base because the uses are from base). The params of base's ctor are high level stuff, so I wasn't sure if it's good to add this as a ctor param, and decided to leave it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109104/new/

https://reviews.llvm.org/D109104