[PATCH] D108394: add tsan shared library

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 1 12:06:57 PDT 2021


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/tsan/CMakeLists.txt:266
                                        clang_rt.tsan_cxx-${arch})
+    add_compiler_rt_runtime(clang_rt.tsan
+      SHARED
----------------
@eugenis I would say that we need to test dynamic runtime, but I noticed that we test Asan but don't hwasan and ubsan. Is there good reason for that or just overlook?


================
Comment at: libcxx/utils/merge_archives.py:11
 from argparse import ArgumentParser
+from ctypes.util import find_library
 import distutils.spawn
----------------
Why do we need this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108394/new/

https://reviews.llvm.org/D108394



More information about the llvm-commits mailing list