[PATCH] D108984: [WebAssembly][libObject] Avoid re-use of Section object during parsing

Wed Sep 1 08:53:40 PDT 2021

dschuff accepted this revision.
dschuff added a comment.

AFAIK we don't have gtest tests for wasm's lib/Object code so I don't want to block this little fix on creating a whole new set of tests. This change to the existing tests looks ok to me.
But I am interested in gtest unit tests more, because I like that style of testing generally.  e.g. gor the file-based tests we have YAML as a convenient way to create test input, but it seems like for gtest tests you'd have to duplicate or write some custom test-harness code to generate inputs. Do you know if there are existing unit tests for lib/Object code, or know of any best practices for testing that library?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108984/new/

https://reviews.llvm.org/D108984