[PATCH] D108984: [WebAssembly][libObject] Avoid re-use of Section object during parsing

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

> If you prefer I can leave this test as is but write a specific regression test in llvm/test/Object instead?

I personally would generally prefer a gtest unit test for library-level changes, as I find the actual testing can be more specific, and less prone to rotting so that the test no longer covers the thing it's supposed to cover. However, I'm not a wasm developer, so I'm not going to ask for it, as there are probably norms there that are better followed.

Anyway, LGTM, but please wait for @dschuff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108984/new/

https://reviews.llvm.org/D108984