[PATCH] D107160: [AArch64] Do not emit an extra zero-extend for i1 argument

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 30 11:37:46 PDT 2021


efriedma added a comment.

For cross-block information, we do some limited tracking in target-independent code.  See FunctionLoweringInfo::ComputePHILiveOutRegInfo.  We could maybe mess with that code to track more information, or add a target hook to SelectionDAG around GetLiveOutRegInfo().  Actually, we could maybe even just feed the info from ComputePHILiveOutRegInfo directly into ComputeKnownBits; we actually keep all the information around already?  (Not sure what the history is here...)

But we can leave that for a followup.  The current SelectionDAG changes seem fine.  I'm not familiar enough with the globalisel bits to approve that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107160/new/

https://reviews.llvm.org/D107160



More information about the llvm-commits mailing list