[PATCH] D108732: [AMDGPU] Invert partial vgpr to agpr spill lane order

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 25 15:36:21 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:1189
+    unsigned RemEltSize = EltSize;
+    for (int LaneS = (RegOffset + EltSize) / 4 - 1, Lane = LaneS,
+             LaneE = RegOffset / 4; Lane >= LaneE; --Lane) {
----------------
Should add a comment explaining why this is done in reverse


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108732/new/

https://reviews.llvm.org/D108732



More information about the llvm-commits mailing list