[PATCH] D108655: [IndVars] Drop check for the validity of rewrite

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM, I believe your reasoning is correct.

Might make sense to add the test case from D108043 <https://reviews.llvm.org/D108043> to show that this is an increase in power (because isValidRewrite was a conservative check)? I believe the only relevant part of that test case is that the phi has a loop-invariant input on the backedge and the exit is known to not be taken on the first iteration (thus the value coming from the backedge must be used) -- I don't think load/store forwarding is relevant there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108655/new/

https://reviews.llvm.org/D108655