[PATCH] D108655: [IndVars] Drop check for the validity of rewrite

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri created this revision.
lebedev.ri added reviewers: efriedma, mkazantsev, reames, nikic, fhahn.
lebedev.ri added a project: LLVM.
Herald added subscribers: javed.absar, hiraditya.
lebedev.ri requested review of this revision.

`isValidRewrite()` checks that the both the original SCEV,
and the rewrite SCEV have the same base pointer.
I //believe//, after all the recent SCEV improvements,
this invariant is already enforced by SCEV itself.

I originally tried changing it into an assert in D108043 <https://reviews.llvm.org/D108043>,
but that showed that it triggers on e.g. https://reviews.llvm.org/D108043#2946621,
where SCEV manages to forward the store to load.

@efriedma @mkazantsev @reames does my understanding i outlied above match the current state of reality?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108655

Files:
  llvm/lib/Transforms/Utils/LoopUtils.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108655.368424.patch
Type: text/x-patch
Size: 4256 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210824/b5443086/attachment.bin>