[PATCH] D108813: [RISCV] Implement CSR seccfg for spec Smepmp

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

Commit message is missing an m from mseccfg.

The name also concerns me, "security config" is extremely broad, so it's not clear it applies specifically to PMP things and it could get confused with other security-related extensions.



================
Comment at: llvm/lib/Target/RISCV/RISCVSystemOperands.td:254
 
+def : SysReg<"mseccfg", 0x747>;
+let isRV32Only = 1 in
----------------
The definitions here are grouped in the same way that they are in the privileged spec. Is the intent that these CSRs will be part of the same group as the existing PMP registers in the table in the CSR Listings section of the spec (table 2.5 in my build from earlier this year)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108813/new/

https://reviews.llvm.org/D108813