[PATCH] D108357: [AMDGPU][GlobalISel] Legalize memcpy family of intrinsics

Mirko Brkusanin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 27 08:49:35 PDT 2021


mbrkusanin updated this revision to Diff 369108.
mbrkusanin added a comment.

Since these combines don't use KnownBitAnalysis or anything similar we can easily use them from legalizer without moving code through CombinerHelper
Our custom legalization now simply calls CombinerHelper methods.

Opposite is also possible: Move everything to LegalizerHelper and have AArch and Mips instantiate LegalizerHelper. @aemerson, @paquette do you have any objection to doing it that way instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108357/new/

https://reviews.llvm.org/D108357

Files:
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
  llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-memcpy.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-memcpyinline.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-memmove.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-memset.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.memcpy.inline.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.memcpy.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.memmove.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.memset.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/prelegalizer-combiner-memcpy-inline.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108357.369108.patch
Type: text/x-patch
Size: 31671 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210827/654af14e/attachment.bin>


More information about the llvm-commits mailing list