[PATCH] D108357: [AMDGPU][GlobalISel] Legalize memcpy family of intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D108357#2954171 <https://reviews.llvm.org/D108357#2954171>, @mbrkusanin wrote:

> This is the same solution from CombinerHelper with minor changes. However it makes more sense to use it in legalizer since it is required for correctness.
>
> AArch64 currently uses those combines in PreLegalizerCombiner. We have 3 options:
>
> 1. Custom AMDGPU lowering (current solution, copies code)
> 2. Use same combines in AMDGPUPreLegalizerCombiner (correctness issue)
> 3. Move combines into LegalizerHelper (AArch64 will be using them in legalizer, I don't see a nice way of using a LegalizerHelper method in combiner).

I think this is a lowering action that belongs in the legalizer helper

> Also which tests should I keep, .ll or .mir?

Both?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108357/new/

https://reviews.llvm.org/D108357